linux-kernel - Re: [PATCH] Additional keys for dell-wmi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49DF26EB.4040106@tudelft.nl>
Date:	Fri, 10 Apr 2009 13:00:59 +0200
From:	Éric Piel <E.A.B.Piel@...elft.nl>
To:	Matthew Garrett <mjg@...hat.com>
Cc:	Rafi Rubin <rafi@...s.upenn.edu>, Len Brown <len.brown@...el.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Additional keys for dell-wmi

Matthew Garrett schreef:
> On Wed, Apr 08, 2009 at 05:16:04PM -0400, Rafi Rubin wrote:
> 
>>  static struct key_entry dell_wmi_keymap[] = {
>>  	{KE_KEY, 0xe045, KEY_PROG1},
>> +	{KE_KEY, 0xe046, KEY_PROG2},
>> +	{KE_KEY, 0xe047, KEY_PROG3},
> 
> Would this make more sense as a switch? That way userspace can know what 
> state the screen is in.
> 
Indeed, that seems more logical. And in addition, there is a switch
called SW_TABLET_MODE, which would fit perfectly.
I guess at initialisation you can consider it is in standard mode, and
actually sort out the real state on the first event received.

Eric

View attachment "E_A_B_Piel.vcf" of type "text/x-vcard" (368 bytes)