linux-kernel - Re: [PATCH 03/30] ipcns: remove useless get/put while CLONE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090410151934.GA16027@us.ibm.com>
Date:	Fri, 10 Apr 2009 10:19:34 -0500
From:	"Serge E. Hallyn" <serue@...ibm.com>
To:	Alexey Dobriyan <adobriyan@...il.com>
Cc:	akpm@...ux-foundation.org, containers@...ts.linux-foundation.org,
	xemul@...allels.com, dave@...ux.vnet.ibm.com, mingo@...e.hu,
	orenl@...columbia.edu, hch@...radead.org,
	torvalds@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 03/30] ipcns: remove useless get/put while CLONE_NEWIPC

Quoting Alexey Dobriyan (adobriyan@...il.com):
> copy_ipcs() doesn't actually copy anything. If new ipcns is created,
> it's created from scratch, in this case get/put on old ipcns isn't needed.
> 
> Signed-off-by: Alexey Dobriyan <adobriyan@...il.com>

Yeah, I like this change just for the diffstat.

Acked-by: Serge Hallyn <serue@...ibm.com>

How about breaking these out from the c/r set?

thanks,
-serge

> ---
> 
>  ipc/namespace.c |    6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> --- a/ipc/namespace.c
> +++ b/ipc/namespace.c
> @@ -50,15 +50,11 @@ struct ipc_namespace *copy_ipcs(unsigned long flags, struct ipc_namespace *ns)
>  {
>  	struct ipc_namespace *new_ns;
> 
> -	BUG_ON(!ns);
> -	get_ipc_ns(ns);
> -
>  	if (!(flags & CLONE_NEWIPC))
> -		return ns;
> +		return get_ipc_ns(ns);
> 
>  	new_ns = clone_ipc_ns(ns);
> 
> -	put_ipc_ns(ns);
>  	return new_ns;
>  }
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/