linux-kernel - Re: [PATCH 04/30] ipcns: add create_ipc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090410222916.GA13873@us.ibm.com>
Date:	Fri, 10 Apr 2009 17:29:16 -0500
From:	"Serge E. Hallyn" <serue@...ibm.com>
To:	Alexey Dobriyan <adobriyan@...il.com>
Cc:	akpm@...ux-foundation.org, containers@...ts.linux-foundation.org,
	xemul@...allels.com, dave@...ux.vnet.ibm.com, mingo@...e.hu,
	orenl@...columbia.edu, hch@...radead.org,
	torvalds@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 04/30] ipcns: add create_ipc_ns()

Quoting Alexey Dobriyan (adobriyan@...il.com):
> clone_ipc_ns() is misnamed, it doesn't clone anything and doesn't uses passed
> parameter. Rename it.
> 
> create_ipc_ns() will be used by C/R to create ipcns on restart.
> 
> Signed-off-by: Alexey Dobriyan <adobriyan@...il.com>

Acked-by: Serge Hallyn <serue@...ibm.com>

> ---
> 
>  include/linux/ipc_namespace.h |    1 +
>  ipc/namespace.c               |    9 ++-------
>  2 files changed, 3 insertions(+), 7 deletions(-)
> 
> --- a/include/linux/ipc_namespace.h
> +++ b/include/linux/ipc_namespace.h
> @@ -97,6 +97,7 @@ static inline int mq_init_ns(struct ipc_namespace *ns) { return 0; }
> 
>  #if defined(CONFIG_IPC_NS)
>  extern void free_ipc_ns(struct ipc_namespace *ns);
> +struct ipc_namespace *create_ipc_ns(void);
>  extern struct ipc_namespace *copy_ipcs(unsigned long flags,
>  				       struct ipc_namespace *ns);
>  extern void free_ipcs(struct ipc_namespace *ns, struct ipc_ids *ids,
> --- a/ipc/namespace.c
> +++ b/ipc/namespace.c
> @@ -14,7 +14,7 @@
> 
>  #include "util.h"
> 
> -static struct ipc_namespace *clone_ipc_ns(struct ipc_namespace *old_ns)
> +struct ipc_namespace *create_ipc_ns(void)
>  {
>  	struct ipc_namespace *ns;
>  	int err;
> @@ -48,14 +48,9 @@ static struct ipc_namespace *clone_ipc_ns(struct ipc_namespace *old_ns)
> 
>  struct ipc_namespace *copy_ipcs(unsigned long flags, struct ipc_namespace *ns)
>  {
> -	struct ipc_namespace *new_ns;
> -
>  	if (!(flags & CLONE_NEWIPC))
>  		return get_ipc_ns(ns);
> -
> -	new_ns = clone_ipc_ns(ns);
> -
> -	return new_ns;
> +	return create_ipc_ns();
>  }
> 
>  /*
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/