linux-kernel - Re: [PATCH 06/30] netns: don't get/put old netns on CLONE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090410223910.GC13873@us.ibm.com>
Date:	Fri, 10 Apr 2009 17:39:10 -0500
From:	"Serge E. Hallyn" <serue@...ibm.com>
To:	Alexey Dobriyan <adobriyan@...il.com>
Cc:	akpm@...ux-foundation.org, containers@...ts.linux-foundation.org,
	xemul@...allels.com, dave@...ux.vnet.ibm.com, mingo@...e.hu,
	orenl@...columbia.edu, hch@...radead.org,
	torvalds@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 06/30] netns: don't get/put old netns on CLONE_NEWNET

Quoting Alexey Dobriyan (adobriyan@...il.com):
> copy_net_ns() doesn't copy anything, it creates fresh netns,
> so get/put of old netns is unneeded.
> 
> Signed-off-by: Alexey Dobriyan <adobriyan@...il.com>

Acked-by: Serge Hallyn <serue@...ibm.com>

> ---
> 
>  net/core/net_namespace.c |    5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> --- a/net/core/net_namespace.c
> +++ b/net/core/net_namespace.c
> @@ -120,10 +120,8 @@ struct net *copy_net_ns(unsigned long flags, struct net *old_net)
>  	struct net *new_net = NULL;
>  	int err;
> 
> -	get_net(old_net);
> -
>  	if (!(flags & CLONE_NEWNET))
> -		return old_net;
> +		return get_net(old_net);
> 
>  	err = -ENOMEM;
>  	new_net = net_alloc();
> @@ -142,7 +140,6 @@ struct net *copy_net_ns(unsigned long flags, struct net *old_net)
>  	if (err)
>  		goto out_free;
>  out:
> -	put_net(old_net);
>  	return new_net;
> 
>  out_free:
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/