linux-kernel - Re: [PATCH] deal with interrupt shadow state for emulated instruction

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <49E10886.8010101@zytor.com>
Date:	Sat, 11 Apr 2009 14:15:50 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Avi Kivity <avi@...hat.com>
CC:	Glauber Costa <glommer@...hat.com>, kvm@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] deal with interrupt shadow state for emulated instruction

Avi Kivity wrote:
>>  
>> -    rip = kvm_rip_read(vcpu);
>> -    rip += vmcs_read32(VM_EXIT_INSTRUCTION_LEN);
>> -    kvm_rip_write(vcpu, rip);
>> +    if (!(interruptibility & interruptibility_mask))
>> +        vmcs_write32(GUEST_INTERRUPTIBILITY_INFO,
>> +                 interruptibility | interruptibility_mask);
>> +    vcpu->arch.interrupt_window_open = 0;
>>   
> 
> Setting both _MOV_SS and _STI is wierd; can't happen on real hardware.
> 

Not at architecturally visible boundaries, for sure.  It can be an
implementation artifact internally to an instruction, though.

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/