linux-kernel - Re: + readahead-record-mmap-read-around-states-in-file_ra_state-checkpatch -fixes.patch added to -mm tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Sat, 11 Apr 2009 12:25:46 +0800
From:	Wu Fengguang <fengguang.wu@...el.com>
To:	akpm@...ux-foundation.org
Cc:	mm-commits@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: +
	readahead-record-mmap-read-around-states-in-file_ra_state-checkpatch
	-fixes.patch added to -mm tree

On Fri, Apr 10, 2009 at 04:41:09PM -0700, Andrew Morton wrote:
> 
> The patch titled
>      readahead-record-mmap-read-around-states-in-file_ra_state-checkpatch-fixes
> has been added to the -mm tree.  Its filename is
>      readahead-record-mmap-read-around-states-in-file_ra_state-checkpatch-fixes.patch
> 
> Before you just go and hit "reply", please:
>    a) Consider who else should be cc'ed
>    b) Prefer to cc a suitable mailing list as well
>    c) Ideally: find the original patch on the mailing list and do a
>       reply-to-all to that, adding suitable additional cc's
> 
> *** Remember to use Documentation/SubmitChecklist when testing your code ***
> 
> See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
> out what to do about this
> 
> The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
> 
> ------------------------------------------------------
> Subject: readahead-record-mmap-read-around-states-in-file_ra_state-checkpatch-fixes
> From: Andrew Morton <akpm@...ux-foundation.org>
> 
> ERROR: code indent should use tabs where possible
> #42: FILE: include/linux/mm.h:1202:
> +^I^I        struct address_space *mapping,$
> 
> total: 1 errors, 0 warnings, 83 lines checked
> 
> /patches/readahead-record-mmap-read-around-states-in-file_ra_state.patch has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 
> Please run checkpatch prior to sending patches

Thanks! I used to do the checks one by one:

        scripts/checkpatch.pl `quilt top`

I'll switch to this script for more productive and complete checks:

        #!/bin/sh
        # Usage: ./check-series < patches/series

        CHECKPATCH=/usr/src/linux/scripts/checkpatch.pl

        while read patch
        do     
                scripts/checkpatch.pl patches/$patch
        done

Thanks,
Fengguang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/