linux-kernel - Re: [PATCH 3/3] [BUGFIX] x86/x86_64: fix IRQ migration triggered active device IRQ interrruption

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <86802c440904110035m4cec46f5n5ab7d43e00f42d9f@mail.gmail.com>
Date:	Sat, 11 Apr 2009 00:35:09 -0700
From:	Yinghai Lu <yhlu.kernel@...il.com>
To:	Gary Hade <garyhade@...ibm.com>
Cc:	"Eric W. Biederman" <ebiederm@...ssion.com>, mingo@...e.hu,
	mingo@...hat.com, tglx@...utronix.de, hpa@...or.com,
	x86@...nel.org, linux-kernel@...r.kernel.org, lcm@...ibm.com
Subject: Re: [PATCH 3/3] [BUGFIX] x86/x86_64: fix IRQ migration triggered 
	active device IRQ interrruption

On Fri, Apr 10, 2009 at 2:39 PM, Gary Hade <garyhade@...ibm.com> wrote:

> move_masked_irq() clears the IRQ_MOVE_PENDING desc->status
> bit before calling the function pointed to by
> desc->chip->set_affinity [e.g. set_ioapic_affinity_irq()]
> AND the content of desc->pending_mask is not used after
>  cpumask_and(desc->affinity, desc->pending_mask, cpu_online_mask);
> which precedes the set_affinity function call.  So, I believe
> this provides the necessary separation between the
> IRQ_MOVE_PENDING/desc->pending_mask useage in move_masked_irq()
> and the IRQ_MOVE_PENDING/desc->pending_mask useage in the code
> that the patch adds.
>
that should be ok, they are proteced by spin_lock(&desc->lock)

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/