linux-kernel - Re: [GIT PULL] MN10300: Move arch headers to arch dir

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090411075549.GA30873@uranus.ravnborg.org>
Date:	Sat, 11 Apr 2009 09:55:49 +0200
From:	Sam Ravnborg <sam@...nborg.org>
To:	Al Viro <viro@...IV.linux.org.uk>
Cc:	Jike Song <albcamus@...il.com>,
	David Howells <dhowells@...hat.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	torvalds@...l.org, akpm@...ux-foundation.org,
	linux-am33-list@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [GIT PULL] MN10300: Move arch headers to arch dir

On Sat, Apr 11, 2009 at 07:43:00AM +0100, Al Viro wrote:
> On Sat, Apr 11, 2009 at 07:45:16AM +0200, Sam Ravnborg wrote:
> > On Sat, Apr 11, 2009 at 11:42:01AM +0800, Jike Song wrote:
> > > On Sat, Apr 11, 2009 at 3:25 AM, Sam Ravnborg <sam@...nborg.org> wrote:
> > > >
> > > > .gitignore is left in include/asm-mn10300.
> > > >
> > > > As the content of that file is obsoleted by your last patch it can safely be deleted.
> > > > Linus - can I ask you to do so?
> > > >
> > > >        Sam
> > > 
> > > off topic: there is also a .gitignore left in include/asm-arm.
> > But its there for a reason.
> > Arm generates mach-types.h and it should be ignored.
> > 
> > include/asm-arm is no longer a sensible place for these files,
> > but for now I have no better place for them so they will
> > stay there for a while.
> 
> How about a single directory for *all* generated headers?  Only linux/version.h
> has many places including it and even that can be dealt with for a moment with
> linux/version.h consisting of #include <gen/version.h>.  The rest doesn't
> need anything like that even for transition period - too few includes to care.

So you suggest: include/gen/

asm-offsets.h, mach-types.h and version.h is the ones with the highest count.

And version.h is an exported header which we cannot move in our exported
set of headers. Fortunately I have just checked in a patch so we can specify
an alternative destination when exporting so this should deal with version.h.

asm-offsets.h and mach-types.h require a small helper file as you suggest,
otherwise it would be a _huge_ patch.

We can later migrate more generated files to this location.
(autoconf.h, config/* etc).

	Sam

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/