linux-kernel - [tip:core/urgent] lockdep: continue lock debugging despite some taints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tip-574bbe782057fdf0490dc7dec906a2dc26363e20@git.kernel.org>
Date:	Sun, 12 Apr 2009 14:45:46 GMT
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	linux-tip-commits@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, hpa@...or.com, mingo@...hat.com,
	peterz@...radead.org, ltp-list@...ts.sourceforge.net,
	fweisbec@...il.com, gregkh@...e.de, tglx@...utronix.de,
	mingo@...e.hu
Subject: [tip:core/urgent] lockdep: continue lock debugging despite some taints

Commit-ID:  574bbe782057fdf0490dc7dec906a2dc26363e20
Gitweb:     http://git.kernel.org/tip/574bbe782057fdf0490dc7dec906a2dc26363e20
Author:     Frederic Weisbecker <fweisbec@...il.com>
AuthorDate: Sat, 11 Apr 2009 03:17:18 +0200
Committer:  Ingo Molnar <mingo@...e.hu>
CommitDate: Sun, 12 Apr 2009 16:10:52 +0200

lockdep: continue lock debugging despite some taints

Impact: broaden lockdep checks

Lockdep is disabled after any kernel taints. This might be convenient
to ignore bad locking issues which sources come from outside the kernel
tree. Nevertheless, it might be a frustrating experience for the
staging developers or those who experience a warning but are focused
on another things that require lockdep.

The v2 of this patch simply don't disable anymore lockdep in case
of TAINT_CRAP and TAINT_WARN events.

Signed-off-by: Frederic Weisbecker <fweisbec@...il.com>
Cc: LTP <ltp-list@...ts.sourceforge.net>
Cc: Peter Zijlstra <peterz@...radead.org>
Cc: Greg KH <gregkh@...e.de>
LKML-Reference: <1239412638-6739-2-git-send-email-fweisbec@...il.com>
Signed-off-by: Ingo Molnar <mingo@...e.hu>


---
 kernel/panic.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/kernel/panic.c b/kernel/panic.c
index 940ca14..934fb37 100644
--- a/kernel/panic.c
+++ b/kernel/panic.c
@@ -217,8 +217,10 @@ void add_taint(unsigned flag)
 	 * Can't trust the integrity of the kernel anymore.
 	 * We don't call directly debug_locks_off() because the issue
 	 * is not necessarily serious enough to set oops_in_progress to 1
+	 * Also we want to keep up lockdep for staging development and
+	 * post-warning case.
 	 */
-	if (__debug_locks_off())
+	if (flag != TAINT_CRAP && flag != TAINT_WARN && __debug_locks_off())
 		printk(KERN_WARNING "Disabling lockdep due to kernel taint\n");
 
 	set_bit(flag, &tainted_mask);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/