linux-kernel - Re: 2.6.30-rc1 (latest git): thinkpad-acpi: cannot control brightness with hotkeys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 12 Apr 2009 01:58:18 -0300
From:	Henrique de Moraes Holschuh <hmh@....eng.br>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Niel Lambrechts <niel.lambrechts@...il.com>,
	"linux.kernel" <linux-kernel@...r.kernel.org>,
	linux-acpi@...r.kernel.org
Subject: Re: 2.6.30-rc1 (latest git): thinkpad-acpi: cannot control
	brightness with hotkeys

On Sat, 11 Apr 2009, Andrew Morton wrote:
> > options thinkpad_acpi experimental=1 hotkey=enable,0xffffff

Someday someone might be able to give me a good reason for why the hell
distros like to do this sort of crap...  but I don't think it will be
anytime soon.

> > Any ideas on how I can regain control over the brightness gas-pedal?

I think what you're experiencing is some sort of breakage in ACPI video...

> > WARNING: at drivers/platform/x86/thinkpad_acpi.c:2954
> > hotkey_enabledisable_warn+0x3e/0x43 [thinkpad_acpi]()
> > thinkpad_acpi: hotkey enable/disable functionality has been removed from
> > the driver. Hotkeys are always enabled.

I will silence the warning for module parameters, thanks for the head's up.
That was indeed an oversight.

But it is a red-herring, it doesn't change the driver behaviour at all in
this case...

> > thinkpad_acpi: Standard ACPI backlight interface available, not loading
> > native one.

And this has always been true for any Lenovo Vista BIOS, it is not new.

I really think we need to get the people dealing with ACPI video in the
loop for this one.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/