[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <86802c440904130850r38a1671es68cd2b4cf436c61f@mail.gmail.com>
Date: Mon, 13 Apr 2009 08:50:28 -0700
From: Yinghai Lu <yhlu.kernel@...il.com>
To: Jeff Garzik <jeff@...zik.org>
Cc: Peer Chen <pchen@...dia.com>, Kuan Luo <kluo@...dia.com>,
Christoph Hellwig <hch@...radead.org>,
linux-kernel@...r.kernel.org, linux-ide@...r.kernel.org,
Ingo Molnar <mingo@...e.hu>,
Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] sata_nv: sgpio for nvidia mcp55 -v3
On Mon, Apr 13, 2009 at 1:18 AM, Jeff Garzik <jeff@...zik.org> wrote:
> Yinghai Lu wrote:
>>
>> Impact: new features
>>
>> based on patch on
>> http://marc.info/?l=linux-ide&m=116289338705418&w=2
>>
>> 1. update the patch for 2.6.19 to latest upstream ( 2.6.28?)
>> 2. fix shared sgpio to support several mcp55 + io55, so every mcp55 have
>> seperate spinlock
>> 3. use scratch_source as numbering of sgpio instead of address of struct,
>> so could go through kexec/kdump
>>
>> v2: revert NV_ON and NV_OFF, so turn on Activity LED all the time when
>> disk is idle.
>> v3: use one timer per sgpio instead of per nv_host, so for mcp55+io55
>> system will use 2 timers
>> instead of 6 timers.
>>
>> Signed-off-by: Yinghai Lu <yinghai@...nel.org>
>>
>> ---
>> drivers/ata/sata_nv.c | 562
>> ++++++++++++++++++++++++++++++++++++++++++++++++++
>> 1 file changed, 562 insertions(+)
>
>
> Is this really over 500 LOC, just to blink some lights from the data xfer
> hot path? :)
>
there is timer to blink the activity led. per sgpio, normally one for
mcp55 and one for io55.
data xfer hot path only set some status.
YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists