[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20090413181733.GA10424@redhat.com>
Date: Mon, 13 Apr 2009 20:17:33 +0200
From: Oleg Nesterov <oleg@...hat.com>
To: Andrew Morton <akpm@...ux-foundation.org>,
David Howells <dhowells@...hat.com>
Cc: Serge Hallyn <serue@...ibm.com>, Steve Dickson <steved@...hat.com>,
Trond Myklebust <Trond.Myklebust@...app.com>,
Al Viro <viro@...iv.linux.org.uk>,
Daire Byrne <Daire.Byrne@...mestore.com>,
linux-kernel@...r.kernel.org
Subject: [PATCH] slow_work_thread() should do the exclusive wait
slow_work_thread() sleeps on slow_work_thread_wq without WQ_FLAG_EXCLUSIVE,
this means that slow_work_enqueue()->__wake_up(nr_exclusive => 1) wakes up
all kslowd threads. Afaics this is not what we want, change slow_work_thread()
to use prepare_to_wait_exclusive().
Signed-off-by: Oleg Nesterov <oleg@...hat.com>
--- 6.30/kernel/slow-work.c~1_SW_EXCLUSIVE 2009-04-06 00:03:42.000000000 +0200
+++ 6.30/kernel/slow-work.c 2009-04-13 19:40:20.000000000 +0200
@@ -372,8 +372,8 @@ static int slow_work_thread(void *_data)
vsmax *= atomic_read(&slow_work_thread_count);
vsmax /= 100;
- prepare_to_wait(&slow_work_thread_wq, &wait,
- TASK_INTERRUPTIBLE);
+ prepare_to_wait_exclusive(&slow_work_thread_wq, &wait,
+ TASK_INTERRUPTIBLE);
if (!freezing(current) &&
!slow_work_threads_should_exit &&
!slow_work_available(vsmax) &&
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists