linux-kernel - Re: [PATCH 2/7] use smp_call_function_single() in arch/x86/kernel/acpi/cstate.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090413233352.GF817@elte.hu>
Date:	Tue, 14 Apr 2009 01:33:52 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Rusty Russell <rusty@...tcorp.com.au>,
	Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org,
	Venkatesh Pallipadi <venkatesh.pallipadi@...el.com>,
	Len Brown <len.brown@...el.com>,
	Zhao Yakui <yakui.zhao@...el.com>,
	Wu Fengguang <fengguang.wu@...el.com>
Subject: Re: [PATCH 2/7] use smp_call_function_single() in
	arch/x86/kernel/acpi/cstate.c


* Andrew Morton <akpm@...ux-foundation.org> wrote:

> On Mon, 13 Apr 2009 09:30:02 +0930 Rusty Russell <rusty@...tcorp.com.au> wrote:
> 
> > From: Andrew Morton <akpm@...ux-foundation.org>
> > 
> > Attempting to rid us of the problematic work_on_cpu().  Just use
> > smp_call_function_single() here.
> > 
> > (Includes fix from Wu Fengguang <fengguang.wu@...el.com>)
> > 
> > Cc: Ingo Molnar <mingo@...e.hu>
> > Cc: Venkatesh Pallipadi <venkatesh.pallipadi@...el.com>
> > Cc: Len Brown <len.brown@...el.com>
> > Cc: Zhao Yakui <yakui.zhao@...el.com>
> > Cc: Wu Fengguang <fengguang.wu@...el.com>
> > Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
> > Signed-off-by: Rusty Russell <rusty@...tcorp.com.au>
> 
> fyi, my canonical not-documented-anywhere format for atttributing the
> folded-in fixups is:
> 
> [fengguang.wu@...el.com: short description goes here]
> Cc: Ingo Molnar <mingo@...e.hu>
> Cc: Venkatesh Pallipadi <venkatesh.pallipadi@...el.com>
> Cc: Len Brown <len.brown@...el.com>
> Cc: Zhao Yakui <yakui.zhao@...el.com>
> Cc: Wu Fengguang <fengguang.wu@...el.com>
> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
> Signed-off-by: Rusty Russell <rusty@...tcorp.com.au>
> 
> and to include that person's Signed-off-by:, if it was provided.

It might not be documented anywhere but it is obvious hence 
self-documenting so i've been using your scheme for quite some time 
for fix foldbacks. Works very well IMO.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/