linux-kernel - Re: [PATCH 2/2] Move FAULT_FLAG_xyz into handle_mm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090414070904.GB23528@wotan.suse.de>
Date:	Tue, 14 Apr 2009 09:09:04 +0200
From:	Nick Piggin <npiggin@...e.de>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Wu Fengguang <fengguang.wu@...el.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Ying Han <yinghan@...gle.com>,
	"linux-mm@...ck.org" <linux-mm@...ck.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Ingo Molnar <mingo@...e.hu>, Mike Waychison <mikew@...gle.com>,
	Rohit Seth <rohitseth@...gle.com>,
	Hugh Dickins <hugh@...itas.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	"H. Peter Anvin" <hpa@...or.com>,
	Török Edwin <edwintorok@...il.com>,
	Lee Schermerhorn <lee.schermerhorn@...com>
Subject: Re: [PATCH 2/2] Move FAULT_FLAG_xyz into handle_mm_fault() callers

On Fri, Apr 10, 2009 at 09:09:53AM -0700, Linus Torvalds wrote:
> 
> From: Linus Torvalds <torvalds@...ux-foundation.org>
> Date: Fri, 10 Apr 2009 09:01:23 -0700
> 
> This allows the callers to now pass down the full set of FAULT_FLAG_xyz
> flags to handle_mm_fault().  All callers have been (mechanically)
> converted to the new calling convention, there's almost certainly room
> for architectures to clean up their code and then add FAULT_FLAG_RETRY
> when that support is added.

I like these patches, no objections.

BTW. I had been even toying with allocating the struct vm_fault structure
further up, and filling in various bits as we we call down. Haven't put
much time into that, but this patch goes one step toward that.. but
arguably this patch is most useful because it allows more "flags" to be
passed down.  Probably not much more flexibility can be gained from
passing down the rest of the vm_fault structure (but I might still try
it again in the hope of a readability improvement).

> 
> Signed-off-by: Linus Torvalds <torvalds@...ux-foundation.org>
> ---
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/