linux-kernel - Re: [PATCH] ext2: fix missing mutex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ea11fea30904140043y1f2e4200oe225a6e2b2a88712@mail.gmail.com>
Date:	Tue, 14 Apr 2009 13:13:49 +0530
From:	Manish Katiyar <mkatiyar@...il.com>
To:	Akinobu Mita <akinobu.mita@...il.com>
Cc:	Jan Kara <jack@...e.cz>, linux-ext4@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ext2: fix missing mutex_unlock in error path

On Tue, Apr 14, 2009 at 1:06 PM, Akinobu Mita <akinobu.mita@...il.com> wrote:
> Add missing mutex_unlock in error path in ext2_quota_write()

This has already been taken I think.

http://patchwork.ozlabs.org/patch/25661/

Thanks -
Manish


>
> Cc: Jan Kara <jack@...e.cz>
> Signed-off-by: Akinobu Mita <akinobu.mita@...il.com>
> ---
> diff --git a/fs/ext2/super.c b/fs/ext2/super.c
> index f983225..5c4afe6 100644
> --- a/fs/ext2/super.c
> +++ b/fs/ext2/super.c
> @@ -1395,8 +1395,10 @@ static ssize_t ext2_quota_write(struct super_block *sb, int type,
>                blk++;
>        }
>  out:
> -       if (len == towrite)
> +       if (len == towrite) {
> +               mutex_unlock(&inode->i_mutex);
>                return err;
> +       }
>        if (inode->i_size < off+len-towrite)
>                i_size_write(inode, off+len-towrite);
>        inode->i_version++;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>



-- 
Thanks -
Manish
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/