linux-kernel - Re: 2.6.28 /proc/diskstats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49E440D9.4020803@kernel.org>
Date:	Tue, 14 Apr 2009 16:52:57 +0900
From:	Tejun Heo <tj@...nel.org>
To:	Daniel Collins <solemnwarning@...emnwarning.no-ip.org>
CC:	linux-kernel@...r.kernel.org
Subject: Re: 2.6.28 /proc/diskstats

Daniel Collins wrote:
> Hi
> 
> Since 2.6.28, fd0 isn't visible in /proc/diskstats from boot, only after
> access/mount. It is visible in /sys/block/ from boot, so there are no
> issues detecting it. This may also affect other devices such as hda but
> I haven't tested this yet, my test system and QEMU both only have
> ram0-ram15 from boot. I have tested 2.6.30-rc1 and found the same
> behavior. Is this a bug or a deliberate change?

Hmm... the reason why fd device is skipped before the first open is
because diskstats_show() skips zero sized devices and open is when the
floppy driver sets the capacity.  I think the original code also
skipped zero sized device.  It could be that the original code
triggered revalidation while the current one doesn't.  I'll dig
deeper.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/