linux-kernel - Re: PATCH 1/3] blktrace: support per-partition tracing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090414075947.GA27003@elte.hu>
Date:	Tue, 14 Apr 2009 09:59:47 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Li Zefan <lizf@...fujitsu.com>
Cc:	Jens Axboe <jens.axboe@...cle.com>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Theodore Ts'o <tytso@....edu>, Shawn Du <duyuyang@...il.com>,
	LKML <linux-kernel@...r.kernel.org>, linux-btrace@...r.kernel.org
Subject: Re: PATCH 1/3] blktrace: support per-partition tracing


* Li Zefan <lizf@...fujitsu.com> wrote:

> --- a/include/linux/blktrace_api.h
> +++ b/include/linux/blktrace_api.h
> @@ -165,8 +165,9 @@ struct blk_trace {
>  
>  extern int blk_trace_ioctl(struct block_device *, unsigned, char __user *);
>  extern void blk_trace_shutdown(struct request_queue *);
> -extern int do_blk_trace_setup(struct request_queue *q,
> -	char *name, dev_t dev, struct blk_user_trace_setup *buts);
> +extern int do_blk_trace_setup(struct request_queue *q, char *name,
> +			      dev_t dev, struct block_device *bdev,
> +			      struct blk_user_trace_setup *buts);
>  extern void __trace_note_message(struct blk_trace *, const char *fmt, ...);
>  
>  /**
> @@ -193,6 +194,7 @@ extern void __trace_note_message(struct blk_trace *, const char *fmt, ...);
>  extern void blk_add_driver_data(struct request_queue *q, struct request *rq,
>  				void *data, size_t len);
>  extern int blk_trace_setup(struct request_queue *q, char *name, dev_t dev,
> +			   struct block_device *bdev,
>  			   char __user *arg);
>  extern int blk_trace_startstop(struct request_queue *q, int start);
>  extern int blk_trace_remove(struct request_queue *q);

Small detail: you forgot about the !CONFIG_BLK_DEV_IO_TRACE case 
here, the wrapper macros there need to be updated.

(no need to resend - i fixed this up in the 1/3 and 3/3 patches)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/