linux-kernel - Re: PATCH 1/3] blktrace: support per-partition tracing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090414083453.GE27003@elte.hu>
Date:	Tue, 14 Apr 2009 10:34:53 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Li Zefan <lizf@...fujitsu.com>
Cc:	Jens Axboe <jens.axboe@...cle.com>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Theodore Ts'o <tytso@....edu>, Shawn Du <duyuyang@...il.com>,
	LKML <linux-kernel@...r.kernel.org>, linux-btrace@...r.kernel.org
Subject: Re: PATCH 1/3] blktrace: support per-partition tracing


* Li Zefan <lizf@...fujitsu.com> wrote:

> >> @@ -193,6 +194,7 @@ extern void __trace_note_message(struct blk_trace *, const char *fmt, ...);
> >>  extern void blk_add_driver_data(struct request_queue *q, struct request *rq,
> >>  				void *data, size_t len);
> >>  extern int blk_trace_setup(struct request_queue *q, char *name, dev_t dev,
> >> +			   struct block_device *bdev,
> >>  			   char __user *arg);
> >>  extern int blk_trace_startstop(struct request_queue *q, int start);
> >>  extern int blk_trace_remove(struct request_queue *q);
> > 
> > Small detail: you forgot about the !CONFIG_BLK_DEV_IO_TRACE case 
> > here, the wrapper macros there need to be updated.
> > 
> 
> Ah, sorry..
> 
> > (no need to resend - i fixed this up in the 1/3 and 3/3 patches)
> > 
> 
> and thanks! (But I think only 1/3 patch needs to be fixed)

3/3 had context dependencies - no functionality dependency.

> The 3rd patch can be for 2.6.30, if Ted or somene else wants to 
> use ftrace-plugin blktrace to trace dm devices in 2.6.30.

ok, good point - we can cherry-pick it over into tracing/urgent 
after Ted reports back his experiences with these changes.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/