linux-kernel - Re: [tip:x86/urgent] x86: pci-swiotlb.c swiotlb_dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090414094852Q.fujita.tomonori@lab.ntt.co.jp>
Date:	Tue, 14 Apr 2009 09:49:05 +0900
From:	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>
To:	mingo@...hat.com, hpa@...or.com, linux-kernel@...r.kernel.org,
	jaswinder@...nel.org, fujita.tomonori@....ntt.co.jp,
	jaswinderrajput@...il.com, tglx@...utronix.de, mingo@...e.hu
Cc:	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:x86/urgent] x86: pci-swiotlb.c swiotlb_dma_ops should be
 static

On Tue, 14 Apr 2009 00:12:52 GMT
tip-bot for Jaswinder Singh Rajput <jaswinder@...nel.org> wrote:

> Commit-ID:  49cc21f93ddc4c17c2be77d9da43a2db69acc0d3
> Gitweb:     http://git.kernel.org/tip/49cc21f93ddc4c17c2be77d9da43a2db69acc0d3
> Author:     Jaswinder Singh Rajput <jaswinder@...nel.org>
> AuthorDate: Sun, 12 Apr 2009 23:24:21 +0530
> Committer:  Ingo Molnar <mingo@...e.hu>
> CommitDate: Tue, 14 Apr 2009 01:35:11 +0200
> 
> x86: pci-swiotlb.c swiotlb_dma_ops should be static
> 
> Impact: reduce kernel size a bit, address sparse warning
> 
> Addresses the problem pointed out by this sparse warning:
> 
>   arch/x86/kernel/pci-swiotlb.c:53:20: warning: symbol 'swiotlb_dma_ops' was not declared. Should it be static?
> 
> For x86: swiotlb_dma_ops can be static, because it's not used outside
> of pci-swiotlb.c
> 
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@...il.com>
> Cc: FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>
> LKML-Reference: <1239558861.3938.2.camel@...alhost.localdomain>
> Signed-off-by: Ingo Molnar <mingo@...e.hu>

Acked-by: FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>


Well, this patch is fine for now. But all the users of swiotlb uses
struct dma_map_ops now so I plan to remove the arch's dma_map_ops
swiotlb_dma_ops.

> 
> ---
>  arch/x86/kernel/pci-swiotlb.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/x86/kernel/pci-swiotlb.c b/arch/x86/kernel/pci-swiotlb.c
> index 34f12e9..221a385 100644
> --- a/arch/x86/kernel/pci-swiotlb.c
> +++ b/arch/x86/kernel/pci-swiotlb.c
> @@ -50,7 +50,7 @@ static void *x86_swiotlb_alloc_coherent(struct device *hwdev, size_t size,
>  	return swiotlb_alloc_coherent(hwdev, size, dma_handle, flags);
>  }
>  
> -struct dma_map_ops swiotlb_dma_ops = {
> +static struct dma_map_ops swiotlb_dma_ops = {
>  	.mapping_error = swiotlb_dma_mapping_error,
>  	.alloc_coherent = x86_swiotlb_alloc_coherent,
>  	.free_coherent = swiotlb_free_coherent,
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/