linux-kernel - Re: alpha: half done futex implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <AE456C27-B568-4835-8843-F2A2E2D8FC32@kernel.crashing.org>
Date:	Tue, 14 Apr 2009 11:40:50 +0200
From:	Segher Boessenkool <segher@...nel.crashing.org>
To:	Richard Henderson <rth@...ddle.net>
Cc:	Matt Turner <mattst88@...il.com>,
	Oliver Falk <oliver@...ux-kernel.at>,
	linux-kernel@...r.kernel.org, linuxppc-dev@...abs.org,
	Ivan Kokshaysky <ink@...assic.park.msu.ru>,
	linux-alpha@...r.kernel.org, Jay Estabrook <jay.estabrook@...com>
Subject: Re: alpha: half done futex implementation

> Also, there's a bug in the powerpc implementation.  It appears that  
> oparg is clobbered, and if stwcx fails the operation will be  
> repeated with incorrect inputs.

If either the lwarx or the stwcx. faults, the routine returns -EFAULT
and doesn't retry (label "3" is the end of the asm).

If the stwcx. fails because the CPU lost the reservation, %1 isn't
clobbered as far as I see?


Segher

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/