linux-kernel - Re: [PATCH] tracing: mark get_parent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 14 Apr 2009 02:11:55 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Steven Rostedt <srostedt@...hat.com>
Cc:	Lai Jiangshan <laijs@...fujitsu.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tracing: mark get_parent_ip() notrace


* Steven Rostedt <srostedt@...hat.com> wrote:

> 
> On Mon, 2009-04-13 at 14:17 +0800, Lai Jiangshan wrote:
> > Frederic Weisbecker wrote:
> > > On Thu, Apr 02, 2009 at 02:18:25PM +0800, Lai Jiangshan wrote:
> > >> Impact: remove redundancy tracing log
> > >>
> > >> When tracer is "function" or "function_graph", too much
> > >> "get_parent_ip" are recorded in ring_buffer.
> > > 
> > > 
> > > Thanks, indeed this get_parent_ip was a bit harrassing
> > > in the traces, though I still don't understand why it is
> > > called so often.
> > > 
> > > Anyway, tracing it seems to me not useful.
> > > 
> > > Acked-by: Frederic Weisbecker <fweisbec@...il.com>
> > > 
> > > 
> > 
> > Hi, Ingo,
> > 	Could you apply this fix?
> > 
> > get_parent_ip() is a helper function for ftace, and it is called
> > by preempt_disable() and preempt_enable(), so it is occurred very
> > often.
> 
> I can pull it in too, if Ingo is busy.

I have put it into tip:sched/urgent - it belongs there file-wise. 
Will go upstream after -rc2 most likely.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/