linux-kernel - Re: [PATCH -tip] x86: cpu_debug.c prepare report if files are less or more then expected

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090414134655.GD27163@elte.hu>
Date:	Tue, 14 Apr 2009 15:46:55 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Jaswinder Singh Rajput <jaswinder@...nel.org>
Cc:	x86 maintainers <x86@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -tip] x86: cpu_debug.c prepare report if files are less
	or more then expected


* Jaswinder Singh Rajput <jaswinder@...nel.org> wrote:

> This will prepare the report to update cpu_debug
> 
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@...il.com>
> ---
>  arch/x86/include/asm/cpu_debug.h |    1 +
>  arch/x86/kernel/cpu/cpu_debug.c  |   12 ++++++++++++
>  2 files changed, 13 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/x86/include/asm/cpu_debug.h b/arch/x86/include/asm/cpu_debug.h
> index 2228020..b64da5d 100644
> --- a/arch/x86/include/asm/cpu_debug.h
> +++ b/arch/x86/include/asm/cpu_debug.h
> @@ -187,6 +187,7 @@ enum cpu_processor_bit {
>  #define	CPU_ALL			(CPU_INTEL_ALL | CPU_AMD_ALL)
>  
>  #define MAX_CPU_FILES		512
> +#define MIN_CPU_FILES		10
>  
>  struct cpu_private {
>  	unsigned		cpu;
> diff --git a/arch/x86/kernel/cpu/cpu_debug.c b/arch/x86/kernel/cpu/cpu_debug.c
> index 46e29ab..1c3ebd4 100644
> --- a/arch/x86/kernel/cpu/cpu_debug.c
> +++ b/arch/x86/kernel/cpu/cpu_debug.c
> @@ -838,6 +838,14 @@ static int cpu_init_allreg(unsigned cpu, struct dentry *dentry)
>  	return err;
>  }
>  
> +/* Send Report to maintainer if files are less or more then expected */ 
> +static void send_report(int files, struct cpuinfo_x86 *cpui)
> +{
> +	pr_info("Please report \"cpu_debug files %d for %x:%x:%x:%x\" to"
> +		" jaswinderrajput@...il.com\n", files, cpui->x86_vendor,
> +		cpui->x86, cpui->x86_model, cpui->x86_mask);

i'd rather see this reported to linux-kernel@...r.kernel.org, plus 
please use a WARN_ONCE() instead of a pr_info(). Hitting this is a 
bug we want to fix.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/