linux-kernel - Re: [PATCH -tip] x86: cpu/intel_cacheinfo.c fix compilation warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090414165433.GC2089@elte.hu>
Date:	Tue, 14 Apr 2009 18:54:33 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Jaswinder Singh Rajput <jaswinder@...nel.org>
Cc:	x86 maintainers <x86@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Mark Langsdorf <mark.langsdorf@....com>,
	Andreas Herrmann <andreas.herrmann3@....com>
Subject: Re: [PATCH -tip] x86: cpu/intel_cacheinfo.c fix compilation
	warnings


* Jaswinder Singh Rajput <jaswinder@...nel.org> wrote:

> On Tue, 2009-04-14 at 15:32 +0200, Ingo Molnar wrote:
> > * Jaswinder Singh Rajput <jaswinder@...nel.org> wrote:
> > 
> > > fix:
> > >   arch/x86/kernel/cpu/intel_cacheinfo.c: In function ‘show_cache_disable’:
> > >   arch/x86/kernel/cpu/intel_cacheinfo.c:712: warning: unused variable ‘node’
> > >   arch/x86/kernel/cpu/intel_cacheinfo.c: In function ‘store_cache_disable’:
> > >   arch/x86/kernel/cpu/intel_cacheinfo.c:739: warning: unused variable ‘node’
> > 
> > you again 'fixed' a warning.
> > 
> > this made you fail to analyze and miss the real reason for this for 
> > example:
> > 
> > >   arch/x86/kernel/cpu/intel_cacheinfo.c:739: warning: unused variable ‘node’
> > 
> > > -	int node = cpu_to_node(cpu);
> > 
> > the local variable is clearly initialized.
> > 
> > The problem is not with that variable - the problem is most likely 
> > with the cpu_to_node() macro not creating a reference to the 'cpu' 
> > variable in a compiler-visible way, in the !NUMA case.
> > 
> > The typical way to solve this is to add a dummy:
> > 
> > 	(void)(cpu)
> > 
> > use to the 'cpu' parameter to the macro definition - or, (which is a 
> > much better solution), to convert it to an inline function.
> > 
> 
> OK send patch:
> [PATCH -tip] x86: k8.h reference to node in node_to_k8_nb_misc for !CONFIG_K8_NB

You sent a patch, but did you read+understand the 
suggestions i made above?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/