linux-kernel - Re: [PATCH] FRV: Fix the section attribute on UP DECLARE_PER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.0904140954160.18124@localhost.localdomain>
Date:	Tue, 14 Apr 2009 09:57:58 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	David Howells <dhowells@...hat.com>
cc:	tj@...nel.org, mingo@...e.hu, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] FRV: Fix the section attribute on UP DECLARE_PER_CPU()



On Tue, 14 Apr 2009, David Howells wrote:
> 
> To fix this, DECLARE_PER_CPU() should simply interpose the same section
> attribute as does DEFINE_PER_CPU().  However, this is made slightly more
> complex by virtue of the fact that there are several variants on DEFINE, so
> these need to be matched by variants of DECLARE.

This needs to be fixed.

We should have the DECLARE_PER_CPU() #defines next to the DEFINE_PER_CPU 
ones, rather than somewhere else.

So moving the logic to <asm-generic/percpu.h> is wrong - make it all be in 
<linux/percpu.h> so that they can be maintained together.

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/