linux-kernel - [tip:sched/urgent] sched: Avoid printing sched_group::__cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tip-728fc565bdfc98dc7086fdcccb3f1e1edf195b20@git.kernel.org>
Date:	Tue, 14 Apr 2009 18:42:33 GMT
From:	tip-bot for Gautham R Shenoy <ego@...ibm.com>
To:	linux-tip-commits@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, ego@...ibm.com, hpa@...or.com,
	mingo@...hat.com, tony.luck@...el.com, tglx@...utronix.de,
	mingo@...e.hu
Subject: [tip:sched/urgent] sched: Avoid printing sched_group::__cpu_power for default case

Commit-ID:  728fc565bdfc98dc7086fdcccb3f1e1edf195b20
Gitweb:     http://git.kernel.org/tip/728fc565bdfc98dc7086fdcccb3f1e1edf195b20
Author:     Gautham R Shenoy <ego@...ibm.com>
AuthorDate: Tue, 14 Apr 2009 09:09:36 +0530
Committer:  Ingo Molnar <mingo@...e.hu>
CommitDate: Tue, 14 Apr 2009 20:39:40 +0200

sched: Avoid printing sched_group::__cpu_power for default case

Impact: reduce syslog clutter

Commit 46e0bb9c12f4 ("sched: Print sched_group::__cpu_power
in sched_domain_debug") produces a messy dmesg output while
attempting to print the sched_group::__cpu_power for each
group in the sched_domain hierarchy.

Fix this by avoid printing the __cpu_power for default cases.
(i.e, __cpu_power == SCHED_LOAD_SCALE).

Reported-by: Tony Luck <tony.luck@...el.com>
Signed-off-by: Gautham R Shenoy <ego@...ibm.com>
Fixed-by: Tony Luck <tony.luck@...el.com>
Cc: a.p.zijlstra@...llo.nl
LKML-Reference: <20090414033936.GA534@...ibm.com>
Signed-off-by: Ingo Molnar <mingo@...e.hu>


---
 kernel/sched.c |    8 ++++++--
 1 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/kernel/sched.c b/kernel/sched.c
index e90e70e..b902e58 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -7367,8 +7367,12 @@ static int sched_domain_debug_one(struct sched_domain *sd, int cpu, int level,
 		cpumask_or(groupmask, groupmask, sched_group_cpus(group));
 
 		cpulist_scnprintf(str, sizeof(str), sched_group_cpus(group));
-		printk(KERN_CONT " %s (__cpu_power = %d)", str,
-						group->__cpu_power);
+
+		printk(KERN_CONT " %s", str);
+		if (group->__cpu_power != SCHED_LOAD_SCALE) {
+			printk(KERN_CONT " (__cpu_power = %d)",
+				group->__cpu_power);
+		}
 
 		group = group->next;
 	} while (group != sd->groups);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/