linux-kernel - Re: [PATCH] Input: add wm97xx accelerated driver for Atmel microprocessors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090414155357.76501a93.akpm@linux-foundation.org>
Date:	Tue, 14 Apr 2009 15:53:57 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	dmitry.torokhov@...il.com, jirislaby@...il.com,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	hans-christian.egtvedt@...el.com,
	broonie@...nsource.wolfsonmicro.com
Subject: Re: [PATCH] Input: add wm97xx accelerated driver for Atmel
 microprocessors

On Fri, 10 Apr 2009 10:53:11 +0100
Mark Brown <broonie@...nsource.wolfsonmicro.com> wrote:

> From: Hans-Christian Egtvedt <hans-christian.egtvedt@...el.com>
> 
> This patch adds an accelerated driver for Atmel AVR32 AT32AP700X
> microprocessors. It uses interrupts on the channel B in the AC97
> controller. Thus, offloading the work queue in the wm97xx-ts driver.
> 
> The driver has been tested with Atmel AVR32 AT32AP7000 and Wolfson
> WM9712 codec.
> 
> The driver can also be easily modified to support Atmel AT91 devices, as
> AT91 and AVR32 share the same AC97C module.
> 
> [Fixed leak of atmel_wm97xx when probe fails. -- broonie]
> 
>
> ...
>
> +static void atmel_wm97xx_acc_pen_up(struct wm97xx *wm)
> +{
> +	struct atmel_wm97xx *atmel_wm97xx = platform_get_drvdata(wm->touch_dev);
> +	int pen_down = gpio_get_value(atmel_wm97xx->gpio_pen);
> +
> +	if (pen_down != 0) {
> +		mod_timer(&atmel_wm97xx->pen_timer, jiffies
> +				+ msecs_to_jiffies(1));

I'd be more comfortable if there was a del_timer_sync() somewhere in
this driver?

> +	} else {
> +		input_report_abs(wm->input_dev, ABS_PRESSURE, 0);
> +		input_report_key(wm->input_dev, BTN_TOUCH, 0);
> +		input_sync(wm->input_dev);
> +	}
> +}
> +

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/