[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <1239682504.7011.46.camel@tropicana>
Date: Mon, 13 Apr 2009 23:15:04 -0500
From: Tom Zanussi <tzanussi@...il.com>
To: Ingo Molnar <mingo@...e.hu>
Cc: Jens Axboe <jens.axboe@...cle.com>,
Steven Rostedt <rostedt@...dmis.org>,
Li Zefan <lizf@...fujitsu.com>, Theodore Ts'o <tytso@....edu>,
Arnaldo Carvalho de Melo <acme@...hat.com>,
LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] blktrace: move trace/ dir to /sys/block/sda/
On Mon, 2009-04-13 at 22:11 +0200, Ingo Molnar wrote:
> * Jens Axboe <jens.axboe@...cle.com> wrote:
>
> > On Mon, Apr 13 2009, Li Zefan wrote:
> > > Impact: allow ftrace-plugin blktrace to trace device-mapper devices
> > >
> > > blktrace can't trace a single partition, so it makes no sense to
> > > have one trace/ dir in each /sys/block/sda/sdaX. Move it to
> > > /sys/block/sda/.
> > >
> > > Thus we fix an issue reported by Ted, that ftrace-plugin
> > > blktrace can't be used to trace device-mapper devices.
> >
> > Perhaps I never committed that patch, but it would be trivial to
> > do partition based blktrace tracing. It's also quite useful. So
> > please don't go changing things to make that harder to support, it
> > would be nicer to just add the (small) bits to support
> > per-partition tracing. It's basically just a start/stop sector
> > range, while some events are per-device and should just be
> > included always.
>
> btw., per tracepoint filters could be used for that. That would
> allow multiple partitions to be traced at once.
>
> blktrace user-space could make use of sector range filters straight
> away [ hm, Tom - do we have the <= comparison operator already, or
> is that still WIP? ] - but i think it's better to do this in a more
The new comparison operators aren't there yet, but will be part of the
new parser, which I'll be getting back to this week.
Tom
> integrated way: via the sysfs API, via /sys/block/sda/sda2/trace/.
>
> So when a partition's trace entry is activated, it would
> auto-install a specific filter expression for sda, with the sector
> range of that partition. Or something like that. How does this
> sound?
>
> Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists