[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1239769058.7852.6.camel@tropicana>
Date: Tue, 14 Apr 2009 23:17:38 -0500
From: Tom Zanussi <tzanussi@...il.com>
To: Li Zefan <lizf@...fujitsu.com>
Cc: Frederic Weisbecker <fweisbec@...il.com>,
LKML <linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...e.hu>,
Steven Rostedt <rostedt@...dmis.org>,
paulmck@...ux.vnet.ibm.com
Subject: Re: [PATCH] tracing/filters: allow on-the-fly filter switching
On Wed, 2009-04-15 at 09:12 +0800, Li Zefan wrote:
> > Ok, the whole design and concept looks nice.
> >
> > But you really need to think about a locking scheme to protect
> > the filters from user files.
> >
>
> I noticed this and fixed it in that
> "[PATCH 7/7] tracing/filters: make filter preds RCU safe"
>
> I'll try to fix it on top of Tom's on-the-fly filter swithcing,
> if Tom hasn't started to do this.
>
No, I hadn't gotten to it yet - feel free to do it if you want,
otherwise I'll get to it soon...
Thanks,
Tom
> > Also, is filter_add_pred() supposed to be available for in-kernel
> > uses by other tracers or something?
> > If this is planned, the locking could be even deeper than my comments.
> >
> > Other than these comments:
> >
> > Acked-by: Frederic Weisbecker <fweisbec@...il.com>
> >
> > Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists