linux-kernel - Re: [PATCH] tracing/filters: allow on-the-fly filter switching

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49E5349A.9080402@cn.fujitsu.com>
Date:	Wed, 15 Apr 2009 09:12:58 +0800
From:	Li Zefan <lizf@...fujitsu.com>
To:	Frederic Weisbecker <fweisbec@...il.com>
CC:	Tom Zanussi <tzanussi@...il.com>,
	LKML <linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...e.hu>,
	Steven Rostedt <rostedt@...dmis.org>,
	paulmck@...ux.vnet.ibm.com
Subject: Re: [PATCH] tracing/filters: allow on-the-fly filter switching

> Ok, the whole design and concept looks nice.
> 
> But you really need to think about a locking scheme to protect
> the filters from user files.
> 

I noticed this and fixed it in that
	"[PATCH 7/7] tracing/filters: make filter preds RCU safe"

I'll try to fix it on top of Tom's on-the-fly filter swithcing,
if Tom hasn't started to do this.

> Also, is filter_add_pred() supposed to be available for in-kernel
> uses by other tracers or something?
> If this is planned, the locking could be even deeper than my comments.
> 
> Other than these comments:
> 
> Acked-by: Frederic Weisbecker <fweisbec@...il.com>
> 
> Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/