linux-kernel - Re: [PATCH] FRV: Fix the section attribute on UP DECLARE_PER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.0904150808550.4132@localhost.localdomain>
Date:	Wed, 15 Apr 2009 08:19:57 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	David Howells <dhowells@...hat.com>
cc:	tj@...nel.org, mingo@...e.hu, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] FRV: Fix the section attribute on UP DECLARE_PER_CPU()



On Wed, 15 Apr 2009, David Howells wrote:
> Linus Torvalds <torvalds@...ux-foundation.org> wrote:
> 
> > Hmm. Why not move it all above the '#include <asm/percpu.h>'?
> 
> There are circular dependencies between the x86 arch headers that both use
> this and are used to implement this, and it's a bit fragile.

Grr. Indeed it seems to be. Nasty. Header files seem to want that 
DECLARE_PER_CPU() thing without all the other baggage that is implied by 
including all of <linux/percpu.h>, so they just include <asm/percpu.h> 
directly instead.

What a mess.

So maybe we could move DEFINE_PER_CPU in there too? It's less than 
perfect, but at least we'd have things together rather than split in 
really odd ways.

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/