linux-kernel - Re: [PATCH] Make radeon_reinitialize_M10() absent if its reference is #ifdef'd out

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1239813627.7443.18.camel@pasglop>
Date:	Wed, 15 Apr 2009 18:40:27 +0200
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	David Howells <dhowells@...hat.com>
Cc:	linux-fbdev-devel@...ts.sourceforge.net, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Make radeon_reinitialize_M10() absent if its reference
 is #ifdef'd out

On Tue, 2009-04-14 at 16:56 +0100, David Howells wrote:
> Make radeon_reinitialize_M10() absent if its reference is #ifdef'd out
> (if
> CONFIG_PM=n or CONFIG_PPC_PMAC=n.  Otherwise a warning is given:
> 
>   CC      drivers/video/aty/radeon_pm.o
> drivers/video/aty/radeon_pm.c:1720: warning: 'radeon_reinitialize_M10'
> defined but not used
> 
> Signed-off-by: David Howells <dhowells@...hat.com>

Nah. You ifdef it with CONFIG_PPC_PMAC, but it can be used on x86
too (see the "BUGFIX" entries).

Cheers,
Ben.

> ---
> 
>  drivers/video/aty/radeon_pm.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> 
> diff --git a/drivers/video/aty/radeon_pm.c
> b/drivers/video/aty/radeon_pm.c
> index 97a1f09..8655bbd 100644
> --- a/drivers/video/aty/radeon_pm.c
> +++ b/drivers/video/aty/radeon_pm.c
> @@ -1716,6 +1716,7 @@ static void radeon_pm_m10_reconfigure_mc(struct radeonfb_info *rinfo)
>  	OUTREG(MC_IND_INDEX, 0);
>  }
>  
> +#if defined(CONFIG_PM) && defined(CONFIG_PPC_PMAC)
>  static void radeon_reinitialize_M10(struct radeonfb_info *rinfo)
>  {
>  	u32 tmp, i;
> @@ -1940,6 +1941,7 @@ static void radeon_reinitialize_M10(struct radeonfb_info *rinfo)
>  	 */
>  	radeon_pm_m10_enable_lvds_spread_spectrum(rinfo);
>  }
> +#endif /* CONFIG_PM && CONFIG_PPC_PMAC */
>  
>  #ifdef CONFIG_PPC_OF
>  

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/