linux-kernel - Re: [PATCH] FRV: Fix the section attribute on UP DECLARE_PER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090415165446.GB10345@elte.hu>
Date:	Wed, 15 Apr 2009 18:54:46 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	David Howells <dhowells@...hat.com>
Cc:	Jeremy Fitzhardinge <jeremy@...p.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>, tj@...nel.org,
	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] FRV: Fix the section attribute on UP DECLARE_PER_CPU()


* David Howells <dhowells@...hat.com> wrote:

> I'd like Linus to pull my first patch, if he will.  That'll at 
> least allow FRV to build.  Could you review it?  That's the email 
> that started this thread, ensubjected:
> 
> 	[PATCH] FRV: Fix the section attribute on UP DECLARE_PER_CPU()

hm, this moves the section defines from a generic header into 
platform headers in essence - not a good move IMO.

Why not start a new linux/percpu_types.h header with just those 
defines in place, include it both from linux/percpu.h and from all 
the asm*/percpu.h files you modify in that patch?

This would fix your build problem minimally - and it would also seed 
the new percpu_types.h file that could start the untangling of this 
dependency hell.

(it would also be much easier to verify for correctness - you just 
move bits and include it trivially in places that need it.)

Am i missing something?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/