linux-kernel - Re: [git-pull -tip] Add -Werror to arch/x86/ files only and fix warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090415193758.GA32675@elte.hu>
Date:	Wed, 15 Apr 2009 21:37:58 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Jaswinder Singh Rajput <jaswinder@...nel.org>
Cc:	x86 maintainers <x86@...nel.org>, Sam Ravnborg <sam@...nborg.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [git-pull -tip] Add -Werror to arch/x86/ files only and fix
	warnings


* Jaswinder Singh Rajput <jaswinder@...nel.org> wrote:

> +config ALLOW_X86_WARNINGS
> +	bool "Continue building x86 despite compiler warnings"
> +	default n
> +	depends on ALLOW_WARNINGS
> +	depends on DEBUG_KERNEL
> +	help
> +	  By enabling this option you will disable -Werror on building
> +	  x86 C files only.

no, it should be something like this:

config ALLOW_X86_WARNINGS
	bool "Continue building x86 despite compiler warnings" if DEBUG_KERNEL
	default y
	help
	  By disabling this option you will enable -Werror builds:
	  i.e. any compiler warning will generate a build 
	  failure. (On arch/x86 files only)

	  Disabe this only if you have a reasonably recent compiler 
	  that does not emit bogus warnings and if you want to help 
	  with fixing warnings. Also choose this if you are an x86 
	  developer trying to make sure that the patches you submit 
	  build warning-free. (The rest of the kernel can emit lots 
	  of build warnings - so your own warnings might be easy to 
	  miss.)

	  Choose Y if unsure.

Note the differences: this will be properly kept 'Y' in most 
situations (allyes, allmod, allno). Also note the explicit 
explanation in the help text.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/