linux-kernel - Re: [RFC][PATCH] vfs: check inode size on no_cached

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090414171114.04a47932.akpm@linux-foundation.org>
Date:	Tue, 14 Apr 2009 17:11:14 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Wu Fengguang <fengguang.wu@...el.com>
Cc:	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	xcf@...c.edu.cn
Subject: Re: [RFC][PATCH] vfs: check inode size on no_cached_page

On Sun, 12 Apr 2009 15:16:05 +0800
Wu Fengguang <fengguang.wu@...el.com> wrote:

> [This patch may not necessarily be merged, but at least we should
>  be aware of the problem.]
> 
> When user space requests past-EOF data, do_generic_file_read() will
> issue a bonus readpage call, which may be unfavorable.
> 
> do_generic_file_read:
>         -> find_page:
>         -> find_get_page()             = NULL
>         -> page_cache_sync_readahead()
>         -> find_get_page()             = NULL
>         -> no_cached_page:
>         -> readpage:
>                 -> nfs_readpage()      = error
>         -> readpage_error:
> 
> Reported-by: Xu Chenfeng <xcf@...c.edu.cn>
> Signed-off-by: Wu Fengguang <fengguang.wu@...el.com>
> ---
>  mm/filemap.c |    5 +++++
>  1 file changed, 5 insertions(+)
> 
> --- mm.orig/mm/filemap.c
> +++ mm/mm/filemap.c
> @@ -1269,6 +1269,11 @@ readpage_error:
>  		goto out;
>  
>  no_cached_page:
> +		isize = i_size_read(inode);
> +		end_index = (isize - 1) >> PAGE_CACHE_SHIFT;
> +		if (unlikely(!isize || index > end_index))
> +			goto out;
> +
>  		/*
>  		 * Ok, it wasn't cached, so we need to create a new
>  		 * page..

Is this a problem which needs to be solved?  userspace does something
silly and the kernel behaves a bit suboptimally?

If thats the only problem here then it's not worth adding fastpath
cycles to fix it?


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/