linux-kernel - Re: [PATCH 2/4] irq: make set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200904151257.44715.rusty@rustcorp.com.au>
Date:	Wed, 15 Apr 2009 12:57:44 +0930
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Yinghai Lu <yinghai@...nel.org>
Cc:	Ingo Molnar <mingo@...e.hu>, Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Gary Hade <garyhade@...ibm.com>, lcm@...ibm.com,
	"Pallipadi, Venkatesh" <venkatesh.pallipadi@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/4] irq: make set_affinity to return status

On Wed, 15 Apr 2009 06:12:52 am Yinghai Lu wrote:
> 
> Impact: prepare to use it to keep affinity consistent
> 
> according to Ingo, change set_affinity() in irq_chip to return int.

I prefer a bool, or an actual -errno rather than -1.  Maybe Ingo feels
differently?

Plus:

> @@ -199,6 +199,8 @@ static void octeon_irq_ciu0_set_affinity
>  	 */
>  	cvmx_read_csr(CVMX_CIU_INTX_EN0(cvmx_get_core_num() * 2));
>  	write_unlock(&octeon_irq_ciu0_rwlock);
> +
> +	reutrn 0;
>  }

Typo.

Thanks,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/