linux-kernel - Re: [PATCH] hugetlbfs: return negative error code for bad mount option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090416050129.GA4083@localhost.localdomain>
Date:	Thu, 16 Apr 2009 14:01:29 +0900
From:	Akinobu Mita <akinobu.mita@...il.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	linux-kernel@...r.kernel.org, wli@...omorphy.com,
	linux-mm@...ck.org, linux-fsdevel@...r.kernel.org,
	stable@...nel.org
Subject: Re: [PATCH] hugetlbfs: return negative error code for bad mount
	option

On Wed, Apr 15, 2009 at 02:59:10PM -0700, Andrew Morton wrote:
> On Mon, 13 Apr 2009 12:56:23 +0900
> Akinobu Mita <akinobu.mita@...il.com> wrote:
> 
> > This fixes the following BUG:
> > 
> > # mount -o size=MM -t hugetlbfs none /huge
> > hugetlbfs: Bad value 'MM' for mount option 'size=MM'
> > ------------[ cut here ]------------
> > kernel BUG at fs/super.c:996!
> 
> I can't tell where this BUG (or WARN?) is happening unless I know
> exactly which kernel version was tested.

Oh, sorry.

> I assume that it is BUG_ON(!mnt->mnt_sb); in vfs_kern_mount()?

Yes. In vfs_kern_mount(), type->get_sb() returns 1 then BUG_ON(!mnt->mnt_sb);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/