linux-kernel - Re: Fix quilt merge error in acpi-cpufreq.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090416080253.GC4507@elte.hu>
Date:	Thu, 16 Apr 2009 10:02:53 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Theodore Tso <tytso@....edu>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Dave Jones <davej@...hat.com>
Subject: Re: Fix quilt merge error in acpi-cpufreq.c


* Theodore Tso <tytso@....edu> wrote:

> On Thu, Apr 16, 2009 at 10:57:05AM +0930, Rusty Russell wrote:
> > Ingo wants them.  Example:
> > 
> > 	lguest: don't expect linear addresses in gdt pvops
> > 
> > 	Impact: fix guest crash 'lguest: bad read address 0x4800000 len 256'
> > 
> > What's more important in the subject line?  That it fixes a crash, or what it
> > does?
> 
> Well, consider that 2 or 3 months later, when we're trying to find 
> a potential commit (say, because we're trying to find a potential 
> fix that needs to be forward ported to a distro kernel, or some 
> such), the initial summary line is what is going to be visible in 
> gitk or via "git log --oneline" (or "git log --pretty=oneline 
> --abbrev-commit" for older git versions).
> 
> So when I try to create git log messages, I try to make the first 
> line useful for folks who might be sorting through potentially 
> thousands of patches via gitk or git log --oneline.  So I might do 
> something like

Hm, have you seen the very simple git log + grep examples i gave, 
about how the impact lines of the APIC code and the scheduler in 
this cycle can be used to summarize a stability track record at a 
glance, out of a much larger body of commits?

Try:

  git log v2.6.29..v2.6.30-rc1 arch/x86/kernel/apic/ | \
                  grep Impact: | sort | uniq -c | sort -n


and:

  git log v2.6.29..v2.6.30-rc1 kernel/sched.c | \
                   grep Impact: | sort | uniq -c | sort -n

on a recent upstream repo.

Thanks,

	Ingo

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/