linux-kernel - Re: [PATCH] tracing: add #include <linux/delay.h> to fix build failure in test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.0904161008080.6495@gandalf.stny.rr.com>
Date:	Thu, 16 Apr 2009 10:08:42 -0400 (EDT)
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Ingo Molnar <mingo@...e.hu>
cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Peter Zijlstra <peterz@...radead.org>,
	Frederic Weisbecker <fweisbec@...il.com>
Subject: Re: [PATCH] tracing: add #include <linux/delay.h> to fix build
 failure in test_work()



On Thu, 16 Apr 2009, Ingo Molnar wrote:
> 
> ------------------------>
> >From 63c14122a54c26122ccdbe596123f8e2b75c3116 Mon Sep 17 00:00:00 2001
> From: Ingo Molnar <mingo@...e.hu>
> Date: Thu, 16 Apr 2009 10:26:51 +0200
> Subject: [PATCH] tracing: add #include <linux/delay.h> to fix build failure in test_work()
> MIME-Version: 1.0
> Content-Type: text/plain; charset=utf-8
> Content-Transfer-Encoding: 8bit
> 
> This build failure occured on a few rare configs:
> 
>  kernel/trace/trace_events.c: In function ?test_work?:
>  kernel/trace/trace_events.c:975: error: implicit declaration of function ?udelay?
>  kernel/trace/trace_events.c:980: error: implicit declaration of function ?msleep?
> 
> delay.h is included in way too many other headers, hiding cases
> where new usage is added without header inclusion.
> 
> Impact: build fix
> Signed-off-by: Ingo Molnar <mingo@...e.hu>

Thanks Ingo!

I don't see this change in tip, do you want me to apply it in my tree?

-- Steve

> ---
>  kernel/trace/trace_events.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
> index 96934f0..791501d 100644
> --- a/kernel/trace/trace_events.c
> +++ b/kernel/trace/trace_events.c
> @@ -15,6 +15,7 @@
>  #include <linux/uaccess.h>
>  #include <linux/module.h>
>  #include <linux/ctype.h>
> +#include <linux/delay.h>
>  
>  #include "trace_output.h"
>  
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/