linux-kernel - Re: [PATCH 1/5] ftrace: use module notifier for function tracer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.0904161152260.20429@gandalf.stny.rr.com>
Date:	Thu, 16 Apr 2009 11:53:19 -0400 (EDT)
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Frederic Weisbecker <fweisbec@...il.com>
cc:	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Peter Zijlstra <peterz@...radead.org>,
	Rusty Russell <rusty@...tcorp.com.au>
Subject: Re: [PATCH 1/5] ftrace: use module notifier for function tracer


On Thu, 16 Apr 2009, Frederic Weisbecker wrote:
> >  
> > +static int ftrace_module_notify(struct notifier_block *self,
> > +				unsigned long val, void *data)
> > +{
> > +	struct module *mod = data;
> > +
> > +	switch (val) {
> > +	case MODULE_STATE_COMING:
> > +		ftrace_init_module(mod, mod->ftrace_callsites,
> > +				   mod->ftrace_callsites +
> > +				   mod->num_ftrace_callsites);
> > +		break;
> > +	case MODULE_STATE_GOING:
> > +		ftrace_release(mod->ftrace_callsites,
> > +			       mod->ftrace_callsites +
> > +			       mod->num_ftrace_callsites);
> > +		break;
> > +	}
> > +
> > +	return 0;
> > +}
> > +#else
> > +static int ftrace_module_notify(struct notifier_block *self,
> > +				unsigned long val, void *data)
> > +{
> > +	return 0;
> > +}
> 
> 
> 
> You don't seem to like my __init idea :)

Nah, just forgot about it.

> 
> 
> 
> > +#endif /* CONFIG_MODULES */
> > +
> > +struct notifier_block ftrace_module_nb = {
> > +	.notifier_call = ftrace_module_notify,
> > +	.priority = 0,
> > +};
> > +
> 
> 
> 
> Neither the __initdata_or_module.

Ooh, I never knew that existed.

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/