[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <49E7580A.1080903@goop.org>
Date: Thu, 16 Apr 2009 09:08:42 -0700
From: Jeremy Fitzhardinge <jeremy@...p.org>
To: Andrea Arcangeli <aarcange@...hat.com>
CC: Andrew Morton <akpm@...ux-foundation.org>,
Izik Eidus <ieidus@...hat.com>, linux-kernel@...r.kernel.org,
kvm@...r.kernel.org, linux-mm@...ck.org, avi@...hat.com,
chrisw@...hat.com, mtosatti@...hat.com, hugh@...itas.com,
kamezawa.hiroyu@...fujitsu.com
Subject: Re: [PATCH 4/4] add ksm kernel shared memory driver.
Andrea Arcangeli wrote:
> On Wed, Apr 15, 2009 at 05:43:03PM -0700, Jeremy Fitzhardinge wrote:
>
>> Shouldn't that be kmap_atomic's job anyway? Otherwise it would be hard to
>>
>
> No because those are full noops in no-highmem kernels. I commented in
> other email why I think it's safe thanks to the wrprotect + smp tlb
> flush of the userland PTE.
>
I think Andrew's query was about data cache synchronization in
architectures with virtually indexed d-cache. On x86 it's a non-issue,
but on architectures for which it is an issue, I assume kmap_atomic does
any necessary cache flushes, as it does tlb flushes on x86 (which may be
none at all, if no mapping actually happens).
J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists