linux-kernel - Re: [RFC][PATCH 1/2] tracing/events: provide string with undefined size support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090416161920.GI6004@nowhere>
Date:	Thu, 16 Apr 2009 18:19:21 +0200
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	Li Zefan <lizf@...fujitsu.com>
Cc:	Ingo Molnar <mingo@...e.hu>, Steven Rostedt <rostedt@...dmis.org>,
	Zhaolei <zhaolei@...fujitsu.com>,
	Tom Zanussi <tzanussi@...il.com>,
	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: [RFC][PATCH 1/2] tracing/events: provide string with undefined
	size support

On Thu, Apr 16, 2009 at 03:54:33PM +0800, Li Zefan wrote:
> >>> +	entry	= ring_buffer_event_data(event);			       \
> >> small nits, below is better since we have only one assignment:
> >>
> >> 	entry = ring_buffer_event_data(event);
> > 
> > 
> > 
> > Hm, I don't understand what you are suggesting.
> > 
> 
> I meant just add a ' ' before '=' instead of a tab:
> 
> entry = ring_buffer_event_data(event);
> entry	= ring_buffer_event_data(event);
> 
> since we don't need to align with other assignment statement.
> 
> but this is just a trivial issue. :)


Ah ok :)
Will fix it (unless I remove this part to address Steven's comment.

Thanks.

 
> --
> Zefan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/