linux-kernel - Re: [PATCH 4/8] irq: only update affinity in chip set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49E7E231.7080301@kernel.org>
Date:	Thu, 16 Apr 2009 18:58:09 -0700
From:	Yinghai Lu <yinghai@...nel.org>
To:	suresh.b.siddha@...el.com
CC:	Ingo Molnar <mingo@...e.hu>, Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Rusty Russell <rusty@...tcorp.com.au>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 4/8] irq: only update affinity in chip set_affinity()
 -v3

Suresh Siddha wrote:
> On Wed, 2009-04-15 at 18:41 -0700, Yinghai Lu wrote:
>> Impact: keep affinity consistent
>>
>> irq_set_affinity() and move_masked_irq() try to assign affinity
>> before calling chip set_affinity(). some archs are assigning again in set_affinity
>> again.
>>
>> something like:
>> cpumask_cpy(desc->affinity, mask);
>> desc->chip->set_affinity(mask);
>>
>> in the failing path, affinity should not be touched.
>>
>> also set_extra_move_desc() ( called by set_affinity)  will rely on the old
>> affinity to decide if need to move irq_desc to different node when logical
>> flat apic mode is used.
>>
>> So try remove those assignment, and make some missed arch to assign affinity
>> in their set_affinity.
>>
> 
> I don't see any arch specific changes in this patchset regarding this.
> Did I miss or currently there are no arch's that needs to get fixed?
> 
will update the comments.

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/