linux-kernel - Re: [microblaze-uclinux] [PATCH 11/11] microblaze: Kconfig: Enable drivers for Microblaze

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1d3f23370904162201s21fc7d90q8bc4aacafa5a7ada@mail.gmail.com>
Date:	Fri, 17 Apr 2009 15:01:21 +1000
From:	John Williams <john.williams@...alogix.com>
To:	microblaze-uclinux@...e.uq.edu.au
Cc:	linux-kernel@...r.kernel.org, Michal Simek <monstr@...str.eu>
Subject: Re: [microblaze-uclinux] [PATCH 11/11] microblaze: Kconfig: Enable 
	drivers for Microblaze

On Thu, Apr 16, 2009 at 7:56 PM,  <monstr@...str.eu> wrote:
> From: Michal Simek <monstr@...str.eu>
>
> Signed-off-by: Michal Simek <monstr@...str.eu>

ACK from a MicroBlaze perspective, but some other comments below:

A note more for the Xilinx PPC folks (ie Grant Likely):

Shouldn't some of these Kconfig depends for PPC be unified?  We have:

>  config XILINX_SYSACE
>        tristate "Xilinx SystemACE support"
> -       depends on 4xx
> +       depends on 4xx || MICROBLAZE

>  config XILINX_HWICAP
>        tristate "Xilinx HWICAP Support"
> -       depends on XILINX_VIRTEX
> +       depends on XILINX_VIRTEX || MICROBLAZE


>  config GPIO_XILINX
>        bool "Xilinx GPIO support"
> -       depends on PPC_OF
> +       depends on PPC_OF || MICROBLAZE
>        help
>          Say yes here to support the Xilinx FPGA GPIO device

Are these all really different options?  PPC_OF?  XILINX_VIRTEX?  4xx?

John
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/