linux-kernel - Re: [PATCH] [28/28] x86: MCE: Implement new status bits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49E866E7.7070507@jp.fujitsu.com>
Date:	Fri, 17 Apr 2009 20:24:23 +0900
From:	Hidetoshi Seto <seto.hidetoshi@...fujitsu.com>
To:	Andi Kleen <andi@...stfloor.org>
CC:	hpa@...or.com, linux-kernel@...r.kernel.org, mingo@...e.hu,
	tglx@...utronix.de
Subject: Re: [PATCH] [28/28] x86: MCE: Implement new status bits

Andi Kleen wrote:
>  static struct severity {
>  	u64 mask;
>  	u64 result;
>  	unsigned char sev;
>  	unsigned char mcgmask;
>  	unsigned char mcgres;
> +	unsigned char ser;
> +	unsigned char context;
>  	char *msg;
>  } severities[] = {
> +#define KERNEL .context = IN_KERNEL
> +#define USER .context = IN_USER
> +#define SER .ser = 1
> +#define NOSER .ser = -1

ser is unsigned or signed?

>  int mce_severity(struct mce *a, int tolerant, char **msg)
>  {
>  	struct severity *s;
> @@ -51,11 +101,14 @@
>  			continue;
>  		if ((a->mcgstatus & s->mcgmask) != s->mcgres)
>  			continue;
> -		if (s->sev > MCE_NO_SEVERITY && (a->status & MCI_STATUS_UC) &&
> -			tolerant < 1)
> -			return MCE_PANIC_SEVERITY;
> +		if ((s->ser == 1 && !mce_ser) || (s->ser == -1 && mce_ser))
> +			continue;
> +		if (s->context && error_context(a) != s->context)
> +			continue;
>  		if (msg)
>  			*msg = s->msg;
> +		if (s->context == IN_KERNEL && panic_on_oops)
> +			return MCE_PANIC_SEVERITY;
>  		return s->sev;
>  	}
>  }

Where did you throw away the statements for "tolerant < 1"?


Thanks,
H.Seto

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/