linux-kernel - Re: [PATCH] [22/28] x86: MCE: Default to panic timeout for machine checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090417131214.GM14687@one.firstfloor.org>
Date:	Fri, 17 Apr 2009 15:12:14 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	Hidetoshi Seto <seto.hidetoshi@...fujitsu.com>
Cc:	Andi Kleen <andi@...stfloor.org>, hpa@...or.com,
	linux-kernel@...r.kernel.org, mingo@...e.hu, tglx@...utronix.de
Subject: Re: [PATCH] [22/28] x86: MCE: Default to panic timeout for machine checks

On Fri, Apr 17, 2009 at 08:24:16PM +0900, Hidetoshi Seto wrote:
> Andi Kleen wrote:
> > Fatal machine checks can be logged to disk after boot, but only if
> > the system did a warm reboot. That's unfortunately difficult with the
> > default panic behaviour, which waits forever and the admin has to
> > press the power button because modern systems usually miss a reset button.
> > This clears the machine checks in the registers and make
> > it impossible to log them.
> > 
> > This patch changes the default for machine check panic to always
> > reboot after 30s. Then the mce can be successfully logged after
> > reboot.
> 
> In case if user already set panic_timeout to 5s, the that user need to
> wait extra 25s for machine check panic... ?

That's true. I'll fix that.

> 
> The idea is good, but I think some switch like "no_reboot_on_mce" would
> be required.

mce=nobootlog should do that.
If someone feels strongly I can add a separate switch.

-Andi

-- 
ak@...ux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/