linux-kernel - Re: [PATCH -tip] remove the BKL: Replace BKL in mount/umount syscalls with a mutex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.0904171039080.4042@localhost.localdomain>
Date:	Fri, 17 Apr 2009 11:03:31 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Jonathan Corbet <corbet@....net>
cc:	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Ingo Molnar <mingo@...e.hu>, Al Viro <viro@...IV.linux.org.uk>,
	Alessio Igor Bogani <abogani@...ware.it>,
	Alexander Viro <viro@....linux.org.uk>,
	Frederic Weisbecker <fweisbec@...il.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Matthew Wilcox <willy@...ux.intel.com>
Subject: Re: [PATCH -tip] remove the BKL: Replace BKL in mount/umount syscalls
 with a mutex

On Fri, 17 Apr 2009, Jonathan Corbet wrote:

> On Fri, 17 Apr 2009 10:21:06 -0700 (PDT)
> Linus Torvalds <torvalds@...ux-foundation.org> wrote:
> 
> > And I know we had patches for file locking BKL-removal at some point. What 
> > happened to them? Were they just broken, or forgotten, or waiting in Jon's 
> > tree, or what?
> 
> Not in my tree, I've not seen them.  I could maybe take a look at that,
> I've just about recovered from my fasync experience...:)

Hmm. It might also just be my fevered imagination. I'd like to say it was 
Matthew Wilcox, but really, my mind is going.

Ahh. Bug google backs me up. As long as I have google, I can keep 
Alzheimer's at bay: "Negative scalability by removal of lock_kernel()" 
thread on lkml back in October 2000. After we had actually done the BKL 
removal.

So we actually did apply it (in 2.4.0-test9, and then reverted it again 
(in -test11, I think). Google for "file_lock_sem fs/locks.c" and see some 
of the discussion. The end result was to go back to the BKL due to Apache 
slowdowns.

But I seem to remember a later patch (in the last year or two) from Willy 
too. Google doesn't help me, so that's probably just my fevered mind. But 
I'm cc'ing Willy anyway.

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/