| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20090417190355.GA21614@elte.hu>
Date: Fri, 17 Apr 2009 21:03:55 +0200
From: Ingo Molnar <mingo@...e.hu>
To: Jaswinder Singh Rajput <jaswinder@...nel.org>
Cc: Sam Ravnborg <sam@...nborg.org>, x86 maintainers <x86@...nel.org>,
LKML <linux-kernel@...r.kernel.org>
Subject: Re: [git-pull -tip] x86: fix section mismatch warnings
* Jaswinder Singh Rajput <jaswinder@...nel.org> wrote:
> On Fri, 2009-04-17 at 18:41 +0200, Ingo Molnar wrote:
> > * Jaswinder Singh Rajput <jaswinder@...nel.org> wrote:
> >
> > > The following changes since commit 88dc4c8e38d64db32907e0bd605f8c1ec4c4d1bd:
> > > Ingo Molnar (1):
> > > Merge branch 'tracing/ftrace'
> > >
> > > are available in the git repository at:
> > >
> > > git://git.kernel.org/pub/scm/linux/kernel/git/jaswinder/linux-2.6-tip.git master
> > >
> > > Jaswinder Singh Rajput (3):
> > > x86: mm/numa_32.c calculate_numa_remap_pages should use __init
> > > x86: apic/es7000_32.c find_unisys_acpi_oem_table and es7000_acpi_madt_oem_check should use __init
> > > x86: smpboot.c wakeup_secondary_cpu_via_nmi do not required __devinit
> >
> > The commit logs lack analysis. The suggestions in the warnings are
> > advisory and can be wrong. Analysis explaining what happened, maybe
> > even when it happened, and what should be done about it to fix that
> > issue is needed in such changelogs.
> >
> > The commits might be correct - or they might be bogus. The commit
> > logs dont give us any help in deciding that. I.e. if you did that
> > work, you should document it. If you _didnt_ do that analysis work,
> > you shouldnt send patches addressing these types of warnings.
> >
>
> I was busy in another stuff, So I am sending analysis of first
> commit. If you want you can apply this patch and ignore others :
>
> [PATCH-tip] x86: mm/numa_32.c calculate_numa_remap_pages should use __init
>
> calculate_numa_remap_pages() is called only by __init initmem_init()
> further calculate_numa_remap_pages is calling:
> __init find_e820_area() and __init reserve_early()
>
> So calculate_numa_remap_pages() should be __init calculate_numa_remap_pages().
>
> Impact: fix Section mismatch warnings
> WARNING: arch/x86/built-in.o(.text+0x82ea3): Section mismatch in reference from the function calculate_numa_remap_pages() to the function .init.text:find_e820_area()
> The function calculate_numa_remap_pages() references
> the function __init find_e820_area().
> This is often because calculate_numa_remap_pages lacks a __init
> annotation or the annotation of find_e820_area is wrong.
>
> WARNING: arch/x86/built-in.o(.text+0x82f5f): Section mismatch in reference from the function calculate_numa_remap_pages() to the function .init.text:reserve_early()
> The function calculate_numa_remap_pages() references
> the function __init reserve_early().
> This is often because calculate_numa_remap_pages lacks a __init
> annotation or the annotation of reserve_early is wrong.
>
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@...il.com>
Yes, this one is perfect, it contains precisely the information we
need. It's also helpful for other reasons: people looking at such
commit logs will learn how to do section warning analysis correct.
Btw., the impact line i added is slightly different:
[ Impact: save memory, address Section mismatch warning ]
Note that the main impact is that we now save a little bit of RAM,
by marking one more function __init.
Below is the full commit.
Thanks,
Ingo
-------------------->
>From 445b9e51e9ebd7eb1b9ba724b38342015769b48e Mon Sep 17 00:00:00 2001
From: Jaswinder Singh Rajput <jaswinder@...nel.org>
Date: Fri, 17 Apr 2009 23:31:20 +0530
Subject: [PATCH] x86: mm/numa_32.c calculate_numa_remap_pages should use __init
calculate_numa_remap_pages() is called only by __init initmem_init()
further calculate_numa_remap_pages is calling:
__init find_e820_area() and __init reserve_early()
So calculate_numa_remap_pages() should be __init calculate_numa_remap_pages().
WARNING: arch/x86/built-in.o(.text+0x82ea3): Section mismatch in reference from the function calculate_numa_remap_pages() to the function .init.text:find_e820_area()
The function calculate_numa_remap_pages() references
the function __init find_e820_area().
This is often because calculate_numa_remap_pages lacks a __init
annotation or the annotation of find_e820_area is wrong.
WARNING: arch/x86/built-in.o(.text+0x82f5f): Section mismatch in reference from the function calculate_numa_remap_pages() to the function .init.text:reserve_early()
The function calculate_numa_remap_pages() references
the function __init reserve_early().
This is often because calculate_numa_remap_pages lacks a __init
annotation or the annotation of reserve_early is wrong.
[ Impact: save memory, address Section mismatch warning ]
Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@...il.com>
Cc: Sam Ravnborg <sam@...nborg.org>
LKML-Reference: <1239991281.3153.4.camel@...satnam>
Signed-off-by: Ingo Molnar <mingo@...e.hu>
---
arch/x86/mm/numa_32.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/mm/numa_32.c b/arch/x86/mm/numa_32.c
index 3daefa0..d253006 100644
--- a/arch/x86/mm/numa_32.c
+++ b/arch/x86/mm/numa_32.c
@@ -257,7 +257,7 @@ void resume_map_numa_kva(pgd_t *pgd_base)
}
#endif
-static unsigned long calculate_numa_remap_pages(void)
+static __init unsigned long calculate_numa_remap_pages(void)
{
int nid;
unsigned long size, reserve_pages = 0;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists