linux-kernel - Re: [Bug #13058] First hibernation attempt fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.0904171408081.4042@localhost.localdomain>
Date:	Fri, 17 Apr 2009 14:12:00 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
cc:	Alan Jenkins <alan-jenkins@...fmail.co.uk>,
	Jens Axboe <jens.axboe@...cle.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Kernel Testers List <kernel-testers@...r.kernel.org>
Subject: Re: [Bug #13058] First hibernation attempt fails



On Fri, 17 Apr 2009, Rafael J. Wysocki wrote:
> 
> Can you please try to reproduce the problem with the appended debug patch
> applied and send the output of dmesg to me?

Maybe something like this instead (or in addition to).

It does "show_mem()" when memory shrinking fails. It will show a _lot_ of 
data.

Untested, but trivial.

		Linus
---
 kernel/power/swsusp.c |    9 ++++++++-
 1 files changed, 8 insertions(+), 1 deletions(-)

diff --git a/kernel/power/swsusp.c b/kernel/power/swsusp.c
index 78c3504..6e70efd 100644
--- a/kernel/power/swsusp.c
+++ b/kernel/power/swsusp.c
@@ -207,9 +207,16 @@ void swsusp_show_speed(struct timeval *start, struct timeval *stop,
 #define SHRINK_BITE	10000
 static inline unsigned long __shrink_memory(long tmp)
 {
+	unsigned long ret;
+
 	if (tmp > SHRINK_BITE)
 		tmp = SHRINK_BITE;
-	return shrink_all_memory(tmp);
+	ret = shrink_all_memory(tmp);
+	if (!ret) {
+		printk("shrink_all_memory(%ld) failed\n", tmp);
+		show_mem();
+	}
+	return ret;
 }
 
 int swsusp_shrink_memory(void)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/