[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20090417151853.6f02d8d3.akpm@linux-foundation.org>
Date: Fri, 17 Apr 2009 15:18:53 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Joe Perches <joe@...ches.com>
Cc: randy.dunlap@...cle.com, torvalds@...ux-foundation.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/10] MAINTAINERS - add script, patterns and misc
updates
On Fri, 17 Apr 2009 15:09:28 -0700
Joe Perches <joe@...ches.com> wrote:
> On Fri, 2009-04-17 at 14:41 -0700, Andrew Morton wrote:
> > Lots of people's scripts/get_maintainer.pl files won't have the `x' bit
> > set because patch(1) is dumb. So for reliability it's best to always do
>
> git at least persisted the "x" bit.
> checkpatch doesn't say to use perl.
>
> > perl ./scripts/get_maintainer.pl
>
> OK by me.
>
> > : akpm:/usr/src/25> perl scripts/get_maintainer.pl -f fs/ext3/inode.c
> > : grep: The -P option is not supported
> > that's odd. `man grep' on this machine says
>
> I changed the script grep to use "-E", which is older.
>
> > : fatal: Not a git repository
> >
> > it whines about not being run in a git directory, but does a decent
> > job anyway.
>
> Oh, I see, you've git installed, but not in your
> /usr/src/25 directory.
>
> I changed the script to verify that a .git directory
> exists before running git.
hm, well, there's benefit in telling the user "hey, you'll get better
results if you run this in your git directory".
> How about with these 2 patches applied?
>
akpm:/usr/src/25> perl scripts/get_maintainer.pl -f fs/ext3/inode.c
Andreas Dilger <adilger@....com>
Andrew Morton <akpm@...ux-foundation.org>
Stephen Tweedie <sct@...hat.com>
linux-ext4@...r.kernel.org
linux-kernel@...r.kernel.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists