linux-kernel - [PATCH]: uvcvideo: fill reserved fields with zero of VIDIOC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <49E9EAC8.9000706@freemail.hu>
Date:	Sat, 18 Apr 2009 16:59:20 +0200
From:	Németh Márton <nm127@...email.hu>
To:	Laurent Pinchart <laurent.pinchart@...net.be>,
	video4linux-list@...hat.com
CC:	LKML <linux-kernel@...r.kernel.org>
Subject: [PATCH]: uvcvideo: fill reserved fields with zero of VIDIOC_QUERYMENU

When querying menu items with VIDIOC_QUERYMENU the reserved field
is not set to zero as required by V4L2 API revision 0.24 [1].
Add this fill.

The patch was tested with v4l-test 0.11 [2] with CNF7129 webcam found
on EeePC 901.

References:
[1] V4L2 API specification, revision 0.24
    http://v4l2spec.bytesex.org/spec/r13317.htm#V4L2-QUERYMENU

[2] v4l-test: Test environment for Video For Linux Two API
    http://v4l-test.sourceforge.net/

Signed-off-by: Márton Németh <nm127@...email.hu>
---
--- linux-2.6.30-rc2/drivers/media/video/uvc/uvc_v4l2.c.orig	2009-04-17 18:31:29.000000000 +0200
+++ linux-2.6.30-rc2/drivers/media/video/uvc/uvc_v4l2.c	2009-04-18 16:43:20.000000000 +0200
@@ -46,6 +46,8 @@ static int uvc_v4l2_query_menu(struct uv
 	struct uvc_menu_info *menu_info;
 	struct uvc_control_mapping *mapping;
 	struct uvc_control *ctrl;
+	__u32 id;
+	__u32 index;

 	ctrl = uvc_find_control(video, query_menu->id, &mapping);
 	if (ctrl == NULL || mapping->v4l2_type != V4L2_CTRL_TYPE_MENU)
@@ -54,6 +56,11 @@ static int uvc_v4l2_query_menu(struct uv
 	if (query_menu->index >= mapping->menu_count)
 		return -EINVAL;

+	id = query_menu->id;
+	index = query_menu->index;
+	memset(query_menu, 0, sizeof(*query_menu));
+	query_menu->id = id;
+	query_menu->index = index;
 	menu_info = &mapping->menu_info[query_menu->index];
 	strlcpy(query_menu->name, menu_info->name, sizeof query_menu->name);
 	return 0;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/